refactor(api): move PasswordResetDemandNotFoundError to src

Co-authored-by: Emmanuelle Bonnemay <emmanuelle.bonnemay@pix.fr>

api/lib/application/error-manager.js

@@ -198,9 +198,6 @@ function _mapToHttpError(error) {
   if (error instanceof DomainErrors.UserNotFoundError) {
     return new HttpErrors.NotFoundError(error.message);
   }
-  if (error instanceof DomainErrors.PasswordResetDemandNotFoundError) {
-    return new HttpErrors.NotFoundError(error.message);
-  }
   if (error instanceof DomainErrors.AlreadyRegisteredEmailAndUsernameError) {
     return new HttpErrors.BadRequestError(error.message);
   }

api/lib/domain/errors.js

@@ -671,20 +671,6 @@ class FileValidationError extends DomainError {
   }
 }
 
-class PasswordResetDemandNotFoundError extends DomainError {
-  constructor(message = "La demande de réinitialisation de mot de passe n'existe pas.") {
-    super(message);
-  }
-
-  getErrorMessage() {
-    return {
-      data: {
-        temporaryKey: ['Cette demande de réinitialisation n’existe pas.'],
-      },
-    };
-  }
-}
-
 // FIXME: used ?
 class SessionWithIdAndInformationOnMassImportError extends DomainError {
   constructor(message = 'Merci de ne pas renseigner les informations de session') {
@@ -709,6 +695,7 @@ class UserAlreadyLinkedToCandidateInSessionError extends DomainError {
     super(message);
   }
 }
+
 class UserNotAuthorizedToUpdateEmailError extends DomainError {
   constructor(message = 'User is not authorized to update email') {
     super(message);
@@ -1063,7 +1050,6 @@ export {
   OrganizationNotFoundError,
   OrganizationTagNotFound,
   OrganizationWithoutEmailError,
-  PasswordResetDemandNotFoundError,
   SendingEmailError,
   SendingEmailToInvalidDomainError,
   SendingEmailToInvalidEmailAddressError,

api/src/identity-access-management/application/http-error-mapper-configuration.js

@@ -6,6 +6,7 @@ import {
   MissingOrInvalidCredentialsError,
   MissingUserAccountError,
   PasswordNotMatching,
+  PasswordResetDemandNotFoundError,
   UserCantBeCreatedError,
   UserShouldChangePasswordError,
 } from '../domain/errors.js';
@@ -32,6 +33,10 @@ const authenticationDomainErrorMappingConfiguration = [
     name: PasswordNotMatching.name,
     httpErrorFn: (error) => new HttpErrors.UnauthorizedError(error.message),
   },
+  {
+    name: PasswordResetDemandNotFoundError.name,
+    httpErrorFn: (error) => new HttpErrors.NotFoundError(error.message),
+  },
   {
     name: UserCantBeCreatedError.name,
     httpErrorFn: (error) => new HttpErrors.UnauthorizedError(error.message),

api/src/identity-access-management/domain/errors.js

@@ -32,6 +32,20 @@ class PasswordNotMatching extends DomainError {
   }
 }
 
+class PasswordResetDemandNotFoundError extends DomainError {
+  constructor(message = "La demande de réinitialisation de mot de passe n'existe pas.") {
+    super(message);
+  }
+
+  getErrorMessage() {
+    return {
+      data: {
+        temporaryKey: ['Cette demande de réinitialisation n’existe pas.'],
+      },
+    };
+  }
+}
+
 class UserCantBeCreatedError extends DomainError {
   constructor(message = "L'utilisateur ne peut pas être créé") {
     super(message);
@@ -51,6 +65,7 @@ export {
   MissingOrInvalidCredentialsError,
   MissingUserAccountError,
   PasswordNotMatching,
+  PasswordResetDemandNotFoundError,
   UserCantBeCreatedError,
   UserShouldChangePasswordError,
 };

api/src/identity-access-management/infrastructure/repositories/reset-password-demand.repository.js

@@ -1,6 +1,6 @@
 import { knex } from '../../../../db/knex-database-connection.js';
-import { PasswordResetDemandNotFoundError } from '../../../../lib/domain/errors.js';
 import { ResetPasswordDemand } from '../../../../lib/infrastructure/orm-models/ResetPasswordDemand.js';
+import { PasswordResetDemandNotFoundError } from '../../domain/errors.js';
 import { ResetPasswordDemand as ResetPasswordDemandModel } from '../../domain/models/ResetPasswordDemand.js';
 
 const RESET_PASSWORD_DEMANDS_TABLE_NAME = 'reset-password-demands';

api/tests/identity-access-management/integration/application/password/password.controller.test.js

@@ -1,6 +1,7 @@
-import { PasswordResetDemandNotFoundError, UserNotFoundError } from '../../../../../lib/domain/errors.js';
+import { UserNotFoundError } from '../../../../../lib/domain/errors.js';
 import { passwordController } from '../../../../../src/identity-access-management/application/password/password.controller.js';
 import { identityAccessManagementRoutes } from '../../../../../src/identity-access-management/application/routes.js';
+import { PasswordResetDemandNotFoundError } from '../../../../../src/identity-access-management/domain/errors.js';
 import { usecases } from '../../../../../src/identity-access-management/domain/usecases/index.js';
 import { InvalidTemporaryKeyError } from '../../../../../src/shared/domain/errors.js';
 import {

api/tests/identity-access-management/integration/domain/usecases/get-user-by-reset-password-demand.usecase.test.js

@@ -1,4 +1,5 @@
-import { PasswordResetDemandNotFoundError, UserNotFoundError } from '../../../../../lib/domain/errors.js';
+import { UserNotFoundError } from '../../../../../lib/domain/errors.js';
+import { PasswordResetDemandNotFoundError } from '../../../../../src/identity-access-management/domain/errors.js';
 import { User } from '../../../../../src/identity-access-management/domain/models/User.js';
 import { resetPasswordService } from '../../../../../src/identity-access-management/domain/services/reset-password.service.js';
 import { getUserByResetPasswordDemand } from '../../../../../src/identity-access-management/domain/usecases/get-user-by-reset-password-demand.usecase.js';

api/tests/identity-access-management/integration/infrastructure/repositories/reset-password-demand.repository.test.js

@@ -1,4 +1,4 @@
-import { PasswordResetDemandNotFoundError } from '../../../../../lib/domain/errors.js';
+import { PasswordResetDemandNotFoundError } from '../../../../../src/identity-access-management/domain/errors.js';
 import { ResetPasswordDemand } from '../../../../../src/identity-access-management/domain/models/ResetPasswordDemand.js';
 import { resetPasswordDemandRepository } from '../../../../../src/identity-access-management/infrastructure/repositories/reset-password-demand.repository.js';
 import { catchErr, databaseBuilder, expect, knex } from '../../../../test-helper.js';

api/tests/identity-access-management/unit/application/http-error-mapper-configuration_test.js

@@ -5,6 +5,7 @@ import {
   MissingOrInvalidCredentialsError,
   MissingUserAccountError,
   PasswordNotMatching,
+  PasswordResetDemandNotFoundError,
   UserCantBeCreatedError,
   UserShouldChangePasswordError,
 } from '../../../../src/identity-access-management/domain/errors.js';
@@ -99,6 +100,23 @@ describe('Unit | Identity Access Management | Application | HttpErrorMapperConfi
     });
   });
 
+  context('when mapping "PasswordResetDemandNotFoundError"', function () {
+    it('returns a NotFoundError Http Error', function () {
+      //given
+      const httpErrorMapper = authenticationDomainErrorMappingConfiguration.find(
+        (httpErrorMapper) => httpErrorMapper.name === PasswordResetDemandNotFoundError.name,
+      );
+      const message = 'Test message error';
+
+      //when
+      const error = httpErrorMapper.httpErrorFn(new PasswordResetDemandNotFoundError(message));
+
+      //then
+      expect(error).to.be.instanceOf(HttpErrors.NotFoundError);
+      expect(error.message).to.equal(message);
+    });
+  });
+
   context('when mapping "UserCantBeCreatedError"', function () {
     it('returns an UnauthorizedError Http Error', function () {
       //given

api/tests/identity-access-management/unit/domain/errors.test.js

@@ -0,0 +1,20 @@
+import { PasswordResetDemandNotFoundError } from '../../../../src/identity-access-management/domain/errors.js';
+import { expect } from '../../../test-helper.js';
+
+describe('Unit | Identity Access Management | Domain | Errors', function () {
+  describe('#PasswordResetDemandNotFoundError', function () {
+    it('has a getErrorMessage method', function () {
+      // given
+      const expectedErrorMessage = {
+        data: {
+          temporaryKey: ['Cette demande de réinitialisation n’existe pas.'],
+        },
+      };
+
+      // then
+      const error = new PasswordResetDemandNotFoundError();
+      expect(error.getErrorMessage).to.be.a('function');
+      expect(error.getErrorMessage()).to.eql(expectedErrorMessage);
+    });
+  });
+});

api/tests/identity-access-management/unit/domain/usecases/get-user-by-reset-password-demand.usecase.test.js

@@ -1,4 +1,5 @@
-import { PasswordResetDemandNotFoundError, UserNotFoundError } from '../../../../../lib/domain/errors.js';
+import { UserNotFoundError } from '../../../../../lib/domain/errors.js';
+import { PasswordResetDemandNotFoundError } from '../../../../../src/identity-access-management/domain/errors.js';
 import { User } from '../../../../../src/identity-access-management/domain/models/User.js';
 import { getUserByResetPasswordDemand } from '../../../../../src/identity-access-management/domain/usecases/get-user-by-reset-password-demand.usecase.js';
 import { InvalidTemporaryKeyError } from '../../../../../src/shared/domain/errors.js';

api/tests/identity-access-management/unit/domain/usecases/update-user-password.usecase.test.js

@@ -1,4 +1,4 @@
-import { PasswordResetDemandNotFoundError } from '../../../../../lib/domain/errors.js';
+import { PasswordResetDemandNotFoundError } from '../../../../../src/identity-access-management/domain/errors.js';
 import { User } from '../../../../../src/identity-access-management/domain/models/User.js';
 import { updateUserPassword } from '../../../../../src/identity-access-management/domain/usecases/update-user-password.usecase.js';
 import { UserNotAuthorizedToUpdatePasswordError } from '../../../../../src/shared/domain/errors.js';

api/tests/integration/application/error-manager_test.js

@@ -215,18 +215,6 @@ describe('Integration | API | Controller Error', function () {
       expect(response.statusCode).to.equal(NOT_FOUND_ERROR);
       expect(responseDetail(response)).to.equal('Ce compte est introuvable.');
     });
-
-    it('responds Not Found when a PasswordResetDemandNotFoundError error occurs', async function () {
-      routeHandler.throws(
-        new DomainErrors.PasswordResetDemandNotFoundError(
-          "La demande de réinitialisation de mot de passe n'existe pas.",
-        ),
-      );
-      const response = await server.requestObject(request);
-
-      expect(response.statusCode).to.equal(NOT_FOUND_ERROR);
-      expect(responseDetail(response)).to.equal("La demande de réinitialisation de mot de passe n'existe pas.");
-    });
   });
 
   context('409 Conflict', function () {

api/tests/unit/domain/errors_test.js

@@ -93,26 +93,6 @@ describe('Unit | Domain | Errors', function () {
     });
   });
 
-  describe('#PasswordResetDemandNotFoundError', function () {
-    it('should export a PasswordResetDemandNotFoundError', function () {
-      expect(errors.PasswordResetDemandNotFoundError).to.exist;
-    });
-
-    it('should have a getErrorMessage method', function () {
-      // given
-      const expectedErrorMessage = {
-        data: {
-          temporaryKey: ['Cette demande de réinitialisation n’existe pas.'],
-        },
-      };
-
-      // then
-      const error = new errors.PasswordResetDemandNotFoundError();
-      expect(error.getErrorMessage).to.be.a('function');
-      expect(error.getErrorMessage()).to.eql(expectedErrorMessage);
-    });
-  });
-
   it('should export a TargetProfileInvalidError', function () {
     expect(errors.TargetProfileInvalidError).to.exist;
   });