WIP deprecate logInfoWithCorrelationIds & logErrorWithCorrelationIds

1024pix · Jul 5, 2024 · c201409 · c201409
1 parent 9ec29d1
commit c201409
Showing 1 changed file with 13 additions and 25 deletions.
diff --git a/api/src/shared/infrastructure/utils/logger.js b/api/src/shared/infrastructure/utils/logger.js
@@ -49,32 +49,14 @@ function extractUserIdFromRequest(request) {
 }
 
 function parseDataForLogger(data) {
-  return typeof data === 'string' || data instanceof String
-    ? {
-        message: data,
-      }
-    : data;
+  return typeof data === 'string' || data instanceof String ? { message: data } : data;
 }
 
-function _logErrorWithCorrelationIds(logger) {
+function _logWithCorrelationIds(loggingFunction) {
   return function (data) {
     const parsedData = parseDataForLogger(data);
     const context = getCorrelationContext();
-    logger.error(
-      {
-        ...context,
-        ...omit(parsedData, 'message'),
-      },
-      get(parsedData, 'message', '-'),
-    );
-  };
-}
-
-function _logInfoWithCorrelationIds(logger) {
-  return function (data) {
-    const parsedData = parseDataForLogger(data);
-    const context = getCorrelationContext();
-    logger.info(
+    loggingFunction(
       {
         ...context,
         ...omit(parsedData, 'message'),
@@ -101,13 +83,19 @@ function _logInfoWithCorrelationIds(logger) {
  * logErrorWithCorrelationIds(data);
  *
  * @param {object} data
+ * @deprecated use logger#error instead
+ */
+const logErrorWithCorrelationIds = _logWithCorrelationIds(internalLogger.error);
+
+/** @param {object} data
+ * Usage : show logErrorWithCorrelationIds
+ * @deprecated use logger#info instead
  */
-const logErrorWithCorrelationIds = _logErrorWithCorrelationIds(internalLogger);
-const logInfoWithCorrelationIds = _logInfoWithCorrelationIds(internalLogger);
+const logInfoWithCorrelationIds = _logWithCorrelationIds(internalLogger.info);
 
 const logger = {
-  error: logErrorWithCorrelationIds,
-  info: logInfoWithCorrelationIds,
+  error: _logWithCorrelationIds(internalLogger.error),
+  info: _logWithCorrelationIds(internalLogger.info),
   warn: internalLogger.warn.bind(internalLogger),
   trace: internalLogger.trace.bind(internalLogger),
   fatal: internalLogger.fatal.bind(internalLogger),