feat(api): add embed non auto to didacticiel-modulix.json

Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr>
1024pix · Jul 3, 2024 · fb9320e · fb9320e
1 parent b8a9039
commit fb9320e
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 0 deletions.
diff --git a/api/src/devcomp/infrastructure/datasources/learning-content/modules/didacticiel-modulix.json b/api/src/devcomp/infrastructure/datasources/learning-content/modules/didacticiel-modulix.json
@@ -320,6 +320,54 @@
         }
       ]
     },
+    {
+      "id": "46577fb1-aadb-49ba-b3fd-721a11da8eb4",
+      "type": "activity",
+      "title": "Embed non-auto",
+      "components": [
+        {
+          "type": "element",
+          "element": {
+            "id": "0e3315fd-98ad-492f-9046-4aa867495d84",
+            "type": "embed-non-auto",
+            "url": "https://epreuves.pix.fr/fake2.html",
+            "height": 640,
+            "title": "Application"
+          }
+        },
+        {
+          "type": "element",
+          "element": {
+            "id": "74d63ec2-f3e3-4ffe-9806-208d33588553",
+            "type": "qcm",
+            "instruction": "<p>Parcourez ces photos trouvées sur le Web : lesquelles correspondent à des situations fictives&#8239;?</p>",
+            "proposals": [
+              {
+                "id": "1",
+                "content": "Photo 1"
+              },
+              {
+                "id": "2",
+                "content": "Photo 2"
+              },
+              {
+                "id": "3",
+                "content": "Photo 3"
+              },
+              {
+                "id": "4",
+                "content": "Photo 4"
+              }
+            ],
+            "feedbacks": {
+              "valid": "<span class=\"feedback__state\">Correct&#8239;!</span>",
+              "invalid": "<span class=\"feedback__state\">Et non&#8239;!</span>"
+            },
+            "solutions": ["1", "2", "4"]
+          }
+        }
+      ]
+    },
     {
       "id": "7cf75e70-8749-4392-8081-f2c02badb0fb",
       "type": "activity",

diff --git a/...omp/unit/infrastructure/datasources/learning-content/validation/element/embed-non-auto.js b/...omp/unit/infrastructure/datasources/learning-content/validation/element/embed-non-auto.js
@@ -0,0 +1,13 @@
+import Joi from 'joi';
+
+import { htmlNotAllowedSchema, uuidSchema } from '../utils.js';
+
+const embedNonAutoElementSchema = Joi.object({
+  id: uuidSchema,
+  type: Joi.string().valid('embed-non-auto').required(),
+  title: htmlNotAllowedSchema.required(),
+  url: Joi.string().uri().required(),
+  height: Joi.number().min(0).required(),
+}).required();
+
+export { embedNonAutoElementSchema };
diff --git a/...ests/devcomp/unit/infrastructure/datasources/learning-content/validation/element/index.js b/...ests/devcomp/unit/infrastructure/datasources/learning-content/validation/element/index.js
@@ -1,3 +1,4 @@
+import { embedNonAutoElementSchema } from './embed-non-auto.js';
 import { imageElementSchema } from './image.js';
 import { qcmElementSchema } from './qcm.js';
 import { qcuElementSchema } from './qcu.js';
@@ -8,6 +9,7 @@ import { videoElementSchema } from './video.js';
 export {
   blockInputSchema,
   blockSelectSchema,
+  embedNonAutoElementSchema,
   imageElementSchema,
   qcmElementSchema,
   qcuElementSchema,

diff --git a/api/tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module.js b/api/tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module.js
@@ -1,6 +1,7 @@
 import Joi from 'joi';
 
 import {
+  embedNonAutoElementSchema,
   imageElementSchema,
   qcmElementSchema,
   qcuElementSchema,
@@ -31,6 +32,7 @@ const elementSchema = Joi.alternatives().conditional('.type', {
     { is: 'qcm', then: qcmElementSchema },
     { is: 'qrocm', then: qrocmElementSchema },
     { is: 'video', then: videoElementSchema },
+    { is: 'embed-non-auto', then: embedNonAutoElementSchema },
   ],
 });
 

diff --git a/high-level-tests/e2e/cypress/integration/pix-app/modulix-a11y.feature b/high-level-tests/e2e/cypress/integration/pix-app/modulix-a11y.feature
@@ -18,6 +18,7 @@ Fonctionnalité: Accessibilité de Modulix
     Quand je vais au grain suivant
     Quand je vais au grain suivant
     Quand je vais au grain suivant
+    Quand je vais au grain suivant
     Alors la page devrait être accessible
     Quand je clique sur "Terminer"
     Et que j'attends 500 ms