[FEATURE] affiche une alerte d'expiration des lots de places (PIX-14008) #10106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
force-pushed
the
PIX-14008/display-places-lots-alert
branch
9 times, most recently
from
030580f
to
41f8276
Compare
machestla
force-pushed
the
PIX-14008/display-places-lots-alert
branch
4 times, most recently
from
3c23b67
to
c754ca9
Compare
lionelB
force-pushed
the
PIX-14008/display-places-lots-alert
branch
2 times, most recently
from
41f8276
to
8bf0494
Compare
xav-car
reviewed
Sep 18, 2024
|
🤖 Xav-Bot 🤖 App (.fr) |
lionelB
force-pushed
the
PIX-14008/display-places-lots-alert
branch
from
d0a005e
to
a17e186
Compare
Comment on lines
80
to
86
| const placesLots = [ | ||
| store.createRecord('organization-places-lot', { | ||
| count: 123, | ||
| activationDate: new Date('2021-12-01'), | ||
| expirationDate: new Date('2021-12-30'), | ||
| status: STATUSES.PENDING, | ||
| }), |
There was a problem hiding this comment.
thought : Je suis pas sur qu'on veuille rajouter des PENDING dans ce cas ci, car le test du dessous, explicite que si un lot est PENDING l'alerte ne s'affiche de toute façon pas
lionelB
force-pushed
the
PIX-14008/display-places-lots-alert
branch
from
a17e186
to
1b2d2e8
Compare
Alexandre-Monney
added
Func Review OK
Alexandre-Monney
force-pushed
the
PIX-14008/display-places-lots-alert
branch
from
1b2d2e8
to
c52eec1
Compare
machestla
reviewed
Sep 18, 2024
|
|
||
| // then | ||
| assert.notOk(screen.queryByRole('alert', { value: t('banners.last-places-lot-available.message') })); | ||
| }); |
There was a problem hiding this comment.
suggestion : rajouter 2 tests :
- vérifier si 2 lots expirent dans les 30 prochains jours qu'on affiche bien qu'une seule fois la bannière
- vérifier, si on a 2 lots et que l'un des deux expire dans moins de 30 jours que cela n'affiche pas la bannière
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Il n'est pas facile de voir que des lot de place arrive à expiration
🤖 Proposition
Afficher au prescripteur admin d’une orga ayant la fonctionnalité Places activée une alerte lorsque le dernier lot actif arrive à expiration dans moins de 30 jours et qu'il n'a pas de lots à venir
🌈 Remarques
RAS
💯 Pour tester
Sur Orga
Sur Admin
PRO_NOT_MANAGINGSur Orga
Sur Admin
PRO_NOT_MANAGINGSur Orga