Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Front - statut béta (PIX-15351) #10611

Merged
merged 4 commits into from
Nov 26, 2024
Merged

[FEATURE] Front - statut béta (PIX-15351) #10611

merged 4 commits into from
Nov 26, 2024

Conversation

dianeCdrPix
Copy link
Contributor

@dianeCdrPix dianeCdrPix commented Nov 21, 2024 •
edited
Loading

🍂 Problème

L'API retourne des modules contenant le paramètres "is-beta", mais l'affichage côté front affiche les modules comme s'ils étaient toujours "beta".

🌰 Proposition

Pour un module ou is-beta = false :

  • Enlever la bannière beta des modules
  • Enlever la mention du formulaire de fin des détails du module
  • Enlever le lien vers le formulaire utilisateur

🎃 Remarques

RAS

🪵 Pour tester

  • Ouvrir le module didacticiel
  • Dans la page de détails, vérifier que ni la bannière "bêta" ni la mention de module bêta n'apparaissent
  • Commencer le module. Vérifier que la bannière "bêta" n'apparaît pas
  • Finir le module. Vérifier dans le recap que ni la bannière "bêta", ni le bouton d'envoi de formulaire n'apparaissent

@dianeCdrPix dianeCdrPix requested a review from a team as a code owner November 21, 2024 13:20
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@dianeCdrPix dianeCdrPix force-pushed the PIX-15351-handle-beta-module-displaying branch 3 times, most recently from df4e5a5 to 45ac9a9 Compare November 21, 2024 14:51
yannbertrand
yannbertrand approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@yannbertrand yannbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niquel

@dianeCdrPix dianeCdrPix force-pushed the PIX-15351-handle-beta-module-displaying branch 3 times, most recently from 22f8fc7 to 920ffab Compare November 25, 2024 16:04
dianeCdrPix and others added 4 commits November 26, 2024 08:28
@dianeCdrPix @yannbertrand @clemlatz
feat(mon-pix): handle isBeta field in module
f519599 
Co-authored-by: Yann Bertrand <yann.bertrand@pix.fr>
Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr>
@dianeCdrPix
feat(mon-pix): add condition to display beta-banner for module's passage
7d01763
@dianeCdrPix @yannbertrand @clemlatz
feat(mon-pix): hide banner and form button for non beta module in recap
f75c06b 
Co-authored-by: Yann Bertrand <yann.bertrand@pix.fr>
Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr>
@dianeCdrPix @yannbertrand @clemlatz
feat(mon-pix): hide text linked to beta module in details
3ffcec1 
Co-authored-by: Yann Bertrand <yann.bertrand@pix.fr>
Co-authored-by: Clément Latzarus <clement.latzarus@pix.fr>
@pix-service-auto-merge pix-service-auto-merge force-pushed the PIX-15351-handle-beta-module-displaying branch from 920ffab to 3ffcec1 Compare November 26, 2024 08:28
@pix-service-auto-merge pix-service-auto-merge merged commit f8fb12b into dev Nov 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbertrand yannbertrand yannbertrand approved these changes

@clemlatz clemlatz clemlatz approved these changes

Assignees

@clemlatz clemlatz

@yannbertrand yannbertrand

@dianeCdrPix dianeCdrPix

Labels
🚀 Ready to Merge team-devcomp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dianeCdrPix @pix-bot-github @clemlatz @yannbertrand @pix-service-auto-merge