[TECH] Déplacer du code relatif à la gestion du cache référentiel depuis le fichier datasource vers des usecases dédiés (PIX-15389) #10617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laura-bergoens
added
👀 Tech Review Needed
👀 Func Review Needed
team-contenu
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
laura-bergoens
force-pushed
the
pix-15389-move-code-from-datasource-to-usecases-for-learning-content-management
branch
from
2d7edd0
to
c3723c8
Compare
nlepage
approved these changes
Nov 24, 2024
api/src/shared/domain/usecases/patch-learning-content-cache-entry.js
Outdated
Show resolved
Hide resolved
api/src/shared/domain/usecases/patch-learning-content-cache-entry.js
Outdated
Show resolved
Hide resolved
api/src/shared/domain/usecases/refresh-learning-content-cache.js
Outdated
Show resolved
Hide resolved
api/src/shared/domain/usecases/schedule-refresh-learning-content-cache-job.js
Outdated
Show resolved
Hide resolved
api/src/shared/infrastructure/datasources/learning-content/datasource.js
Outdated
Show resolved
Hide resolved
laura-bergoens
force-pushed
the
pix-15389-move-code-from-datasource-to-usecases-for-learning-content-management
branch
3 times, most recently
from
9e7ceea
to
ddd2566
Compare
laura-bergoens
force-pushed
the
pix-15389-move-code-from-datasource-to-usecases-for-learning-content-management
branch
from
ddd2566
to
72ad5e7
Compare
laura-bergoens
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
deleted the
pix-15389-move-code-from-datasource-to-usecases-for-learning-content-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Aujourd'hui le code relatif à la gestion du référentiel se trouve dans le fichier datasource.
Or ce fichier ne devrait définir que des méthodes génériques de manipulation des données du référentiel, mais pas sa gestion (rafraîchissement, initialisation ou patch d'une entrée par exemple).
🌰 Proposition
Déplacer ce code dans des usecases dédiés.
🎃 Remarques
🪵 Pour tester
Il faut tester tous les trucs relatifs au réf comme :