Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] Remplacer des boutons par des PixButton pour gérer le chargement. #2031

Merged
merged 9 commits into from
Nov 2, 2020
Merged

[TECH] Remplacer des boutons par des PixButton pour gérer le chargement. #2031

merged 9 commits into from
Nov 2, 2020

Conversation

MelanieMEB
Copy link
Member

@MelanieMEB MelanieMEB commented Oct 19, 2020 •
edited
Loading

🦄 Problème

  • Plusieurs boutons ne gèrent pas le chargement et permettent de cliquer plusieurs fois
  • Ce système est présents sur certains boutons, avec des méthodes de dev différentes

🤖 Solution

  • Utiliser PixButton qui permet de gérer le chargement

💯 Pour tester

Il faut mieux se mettre en fast3G pour vérifier cette PR

  • Vérifier les boutons des campagnes, avec ou sans erreurs : Lancer une campagne, Donner son identifiant, Lancer la campagne sur la page présentation
  • Cliquer sur le bouton retenter d'une compétence
    Il ne doit plus y avoir plusieurs appels en cas de clics multiples

@MelanieMEB MelanieMEB added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Oct 19, 2020
@pix-service
Copy link
Contributor

I'm deploying this PR to these urls:

Please check it out!

@MelanieMEB MelanieMEB added cross-team Toutes les équipes de dev team-evaluation PR relatives à l'expérience d'évaluation labels Oct 20, 2020
@MelanieMEB MelanieMEB marked this pull request as ready for review October 22, 2020 12:34
@jbuget jbuget force-pushed the use-pix-button branch 2 times, most recently from 00afebb to 441777b Compare October 22, 2020 12:52
MathieuGilet
MathieuGilet approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@MathieuGilet MathieuGilet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool ce composant, merci !

jbuget
jbuget suggested changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@jbuget jbuget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Régression fonctionnelle

mon-pix/app/templates/components/campaign-start-block.hbs Outdated Show resolved Hide resolved
sbedeau
sbedeau approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@sbedeau sbedeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Techniquement OK
A voir pour le problème fonctionnel

praise: PR stylée 🙏

@MelanieMEB MelanieMEB force-pushed the use-pix-button branch 6 times, most recently from a6eb0e8 to c6bb830 Compare October 28, 2020 11:16
@MelanieMEB MelanieMEB added 🚀 Ready to Merge and removed 👀 Func Review Needed Need PO validation for this functionally 👀 Tech Review Needed labels Oct 29, 2020
@MelanieMEB MelanieMEB force-pushed the use-pix-button branch 2 times, most recently from 3f65fce to 663b742 Compare October 30, 2020 09:50
@pix-service-auto-merge pix-service-auto-merge merged commit 6d7fcda into dev Nov 2, 2020
@pix-service-auto-merge pix-service-auto-merge deleted the use-pix-button branch November 2, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrc chrc chrc left review comments

@celineung celineung celineung left review comments

@jbuget jbuget jbuget approved these changes

@MathieuGilet MathieuGilet MathieuGilet approved these changes

@jonasgrilleres jonasgrilleres jonasgrilleres approved these changes

@sbedeau sbedeau sbedeau approved these changes

Assignees
No one assigned
Labels
cross-team Toutes les équipes de dev 🚀 Ready to Merge team-evaluation PR relatives à l'expérience d'évaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@MelanieMEB @pix-service @chrc @jbuget @MathieuGilet @jonasgrilleres @celineung @sbedeau @laura-bergoens @pix-service-auto-merge