[FEATURE] Utiliser le package ember-testing-library dans Pix App (PIX-4983). #4460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm deploying this PR to these urls:
Please check it out! |
yannbertrand
approved these changes
May 25, 2022
|
Le package tant attendu ! Bravo ! |
Libouk
approved these changes
May 25, 2022
Thomasevano
approved these changes
May 27, 2022
|
Salut, on peut merge ? |
pix-service-auto-merge
force-pushed
the
pix-4983-user-ember-testing-library-in-pix-app
branch
from
cde3cda to
7a22c6c
Compare
pix-service-auto-merge
deleted the
pix-4983-user-ember-testing-library-in-pix-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
L'application Pix App était la seule à ne pas utiliser le package ember-testing-library.
Une des raisons à cela était un soucis de wrapper sur le visit de /ember/test-helpers (voir PR #4114 ) qui a été corrigé.
🤖 Solution
Utiliser le package ember-testing-library dans les tests
🌈 Remarques
On a juste utilisé TL dans un test d'acceptance et d'intégration pour vérifier que tout fonctionne.
💯 Pour tester
Les tests passent ✅