Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Lancement et hauteur automatiques d'embed (PIX-13211) #9406

Merged
merged 5 commits into from
Jul 8, 2024
Merged

[FEATURE] Lancement et hauteur automatiques d'embed (PIX-13211) #9406

merged 5 commits into from
Jul 8, 2024
+120 −28

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Jun 28, 2024 •
edited
Loading

🦄 Problème

  • Pour certains embeds (QCU/QCM images, carousel), on ne veut pas de l'overlay de lancement.
  • On a du double scroll sur les épreuves avec embed quand la largeur de la fenêtre est trop petite.

🤖 Proposition

Écouter de nouveaux messages envoyés par les embeds :

  • un message height permettant de changer la hauteur de l'iframe
  • un message auto-launch permettant de lancer automatiquement l'embed

🌈 Remarques

N/A

💯 Pour tester

Faire une preview de challenge1anilZTmbS1zAU sur la RA.

@nlepage nlepage self-assigned this Jun 28, 2024
@nlepage nlepage changed the title feat: set embed height according to embed messages [FEATURE] Hauteur automatique d'embed (PIX-13211) Jun 28, 2024
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@nlepage nlepage force-pushed the pix-13211-embed-auto-height branch 4 times, most recently from b6d920c to aaa8c46 Compare June 28, 2024 15:00
@nlepage nlepage marked this pull request as ready for review July 1, 2024 09:25
@nlepage nlepage changed the title [FEATURE] Hauteur automatique d'embed (PIX-13211) [FEATURE] Lancement et hauteur automatiques d'embed (PIX-13211) Jul 2, 2024
@nlepage nlepage force-pushed the pix-13211-embed-auto-height branch 3 times, most recently from b264ba6 to f347a48 Compare July 2, 2024 15:45
Eithliu
Eithliu approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@Eithliu Eithliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞 🥝 🍒 🍓 LGTM 🍓 🍒 🥝 🌞

@pix-service-auto-merge pix-service-auto-merge merged commit f8741a5 into dev Jul 8, 2024
6 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-13211-embed-auto-height branch July 8, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eithliu Eithliu Eithliu approved these changes

Assignees

@nlepage nlepage

Labels
Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-contenu PR relatives à l'équipe Contenu Tech Review OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nlepage @pix-bot-github @Eithliu @pix-service-auto-merge