Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13262) #9444

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

bpetetot
Copy link
Contributor

@bpetetot bpetetot commented Jul 3, 2024

🦄 Problème

Les routes DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} sont encore dans lib.

🤖 Proposition

Les migrer dans src et 2 routes et le code associé (use case et repo)

🌈 Remarques

N/A

💯 Pour tester

Test de DELETE /api/organizations/{id}/invitations/{organizationInvitationId}

  1. Se connecter à pix orga (ex: allorga@example.net)
  2. Aller sur Equipes
  3. Envoyer une invitation
  4. Annuler l'invitation

L'invitation est supprimée

Test de DELETE /api/admin/organizations/{id}/invitations/{organizationInvitationId}

  1. Se connecter à pix admin (ex: superadmin@example.net)
  2. Aller sur une organisation
  3. Envoyer une invitation
  4. Annuler l'invitation

L'invitation est supprimée

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@bpetetot bpetetot force-pushed the pix-13626 branch 2 times, most recently from b3c8b5e to 5ba3f04 Compare July 3, 2024 13:16
@er-lim er-lim added this to the Bounded context migration milestone Jul 3, 2024
@er-lim er-lim changed the title [TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13626) [TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13626) Jul 3, 2024
@er-lim er-lim changed the title [TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13626) [TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13262)) Jul 4, 2024
@er-lim er-lim changed the title [TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13262)) [TECH] Migrer la route DELETE /api/organizations/{id}/invitations/{organizationInvitationId} et /api/admin/organizations/{id}/invitations/{organizationInvitationId} dans src/team (PIX-13262) Jul 4, 2024
@bpetetot bpetetot marked this pull request as ready for review July 4, 2024 12:09
@bpetetot bpetetot requested a review from a team as a code owner July 4, 2024 12:09
Copy link
Contributor

@EmmanuelleBonnemay EmmanuelleBonnemay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lu et testé avec succès en local sur Firefox

Copy link
Contributor

@mariannebost mariannebost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lu et testé en RA sur Chrome ✅

bpetetot and others added 4 commits July 8, 2024 15:21
into src/team

Co-authored-by: Benjamin Petetot <benjamin.petetot@pix.fr>
Co-authored-by: Eric Lim <eric.lim@pix.fr>
in src/team/domain/error.js

Co-authored-by: Benjamin Petetot <benjamin.petetot@pix.fr>
Co-authored-by: Eric Lim <eric.lim@pix.fr>
@pix-service-auto-merge pix-service-auto-merge merged commit bd2f2ec into dev Jul 8, 2024
6 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-13626 branch July 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants