Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Éviter la purge de la table certification-center-features lors de l'éxécution du script d'ajout de centre pilote pour la séparation (PIX-13280) #9453

Conversation

matthieu-octo
Copy link
Contributor

@matthieu-octo matthieu-octo commented Jul 4, 2024

🦄 Problème

Lors de l'exécution du script d'ajout de centre pilote pour la feature de la séparation pix/pix+, la table certification-center-features était entièrement vidée avant de rajout les nouvelles entrées, et même si des centres pilotes pour d'autres features son enregistrés.

🤖 Proposition

Écraser uniquement les centres pilotes pour la séparation pix/pix+

🌈 Remarques

Difficile de tester la non suppression des centres pilotes pour d'autres features (s'appuyer sur les tests)

💯 Pour tester

Vérifier que le script fonctionne toujours comme prévu

  • Créer un centre pilote V3 sur Pix Admin avec superadmin@example.net
  • Créer un centre non pilote V3 sur Pix Admin
  • Mettre ces deux centres dans un CSV (voir example ci-dessous)
  • Lancer le script, vérifier que le script refuse le centre V2
  • Enlever le centre V2 du CSV
  • Relancer le script, vérifier que pas d'erreurs
  • Vérifier sur Pix Admin (rafraichir la page) que le centre V3 a désormais bien l'habilitation pilote de séparation
  • Vérifier sur Pix Admin que le centre V2 lui n'a pas l'habilitation

Exemple de CSV :

certification_center_id;
xxxx;
yyyyyy;

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@AndreiaPena AndreiaPena changed the title [TECH] Éviter la purge de la table certification-center-features lors de l'exéction du script d'ajout de centre pilote pour la séparation (PIX-13280) [TECH] Éviter la purge de la table certification-center-features lors de l'éxécution du script d'ajout de centre pilote pour la séparation (PIX-13280) Jul 5, 2024
@matthieu-octo matthieu-octo force-pushed the pix-13280-improve-import-pilot-centers-of-complementary-alone-feature-script branch from 8d7c58d to 4058205 Compare July 9, 2024 09:08
@P-Jeremy P-Jeremy added Func Review OK PO validated functionally the PR and removed 👀 Func Review Needed labels Jul 9, 2024
Copy link
Contributor

@Steph0 Steph0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test func ✔️

Centre V2

[12:20][osc-fr1] Scalingo:pix-api-review-pr9453 ~ $ node scripts/certification/next-gen/import-complementary-alone-feature-pilot-certification-centers-from-csv.js test.csv
{"level":30,"time":1720527619461,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Starting script import-pilot-certification-centers-from-csv"}
{"level":30,"time":1720527619461,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Checking test.csv data file..."}
{"level":30,"time":1720527619465,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527619465,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Reading and parsing csv data file... "}
{"level":30,"time":1720527619466,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527619466,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Veryfing certification centers eligibility as pilots... "}
{"level":50,"time":1720527619543,"pid":50,"hostname":"pix-api-review-pr9453-one-off-1701","err":{"type":"Error","message":"V2 certification centers : 8006 are not allowed as pilots","stack":"Error: V2 certification centers : 8006 are not allowed as pilots\n    at allowOnlyV3CertificationCenters (file:///app/scripts/certification/next-gen/import-complementary-alone-feature-pilot-certification-centers-from-csv.js:50:11)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async main (file:///app/scripts/certification/next-gen/import-complementary-alone-feature-pilot-certification-centers-from-csv.js:75:5)\n    at async file:///app/scripts/certification/next-gen/import-complementary-alone-feature-pilot-certification-centers-from-csv.js:113:7"},"msg":"V2 certification centers : 8006 are not allowed as pilots"}

Centre V3

 node scripts/certification/next-gen/import-complementary-alone-feature-pilot-certification-centers-from-csv.js test.csv
{"level":30,"time":1720527683952,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Starting script import-pilot-certification-centers-from-csv"}
{"level":30,"time":1720527683952,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Checking test.csv data file..."}
{"level":30,"time":1720527683956,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527683956,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Reading and parsing csv data file... "}
{"level":30,"time":1720527683957,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527683957,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Veryfing certification centers eligibility as pilots... "}
{"level":30,"time":1720527684036,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527684039,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Retrieving certification center pilots... "}
{"level":30,"time":1720527684039,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527684039,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Inserting pilot certification center ids in database... "}
{"level":30,"time":1720527684051,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":""}
{"level":30,"time":1720527684054,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Added lines: 1"}
{"level":30,"time":1720527684054,"pid":62,"hostname":"pix-api-review-pr9453-one-off-1701","msg":"Done."}

Résultat
image
image

@matthieu-octo matthieu-octo force-pushed the pix-13280-improve-import-pilot-centers-of-complementary-alone-feature-script branch 2 times, most recently from 16df427 to 28723ad Compare July 10, 2024 08:43
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-13280-improve-import-pilot-centers-of-complementary-alone-feature-script branch from 28723ad to e94ed05 Compare July 10, 2024 08:52
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-13280-improve-import-pilot-centers-of-complementary-alone-feature-script branch from e94ed05 to d4d96ce Compare July 10, 2024 08:58
@pix-service-auto-merge pix-service-auto-merge merged commit 1c9a52b into dev Jul 10, 2024
6 of 7 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-13280-improve-import-pilot-centers-of-complementary-alone-feature-script branch July 10, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants