[FEATURE] Ajout d'une bordure à gauche des feedbacks (PIX-13261) #9458
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
dlahaye
commented
Jul 5, 2024
AnaisAllamand
approved these changes
Jul 8, 2024
dlahaye
commented
Jul 8, 2024
clemlatz
approved these changes
Jul 8, 2024
reibecca
approved these changes
Jul 8, 2024
dlahaye
force-pushed
the
PIX-13261-add-border-to-feedbacks
branch
from
b027a16
to
0cf7f53
Compare
pix-service-auto-merge
force-pushed
the
PIX-13261-add-border-to-feedbacks
branch
from
0cf7f53
to
bf125c3
Compare
|
Coucou, pourrait-on ajouter 6 px de padding entre la bordure et le texte. En fait j'ai l'impression qu'il ne prends pas en compte la largeur de la bordure mais commence à -6px donc passer de 3X de padding à 4X. |
Co-authored-by: Rébecca Kaci <82950611+reibecca@users.noreply.github.com>
dlahaye
force-pushed
the
PIX-13261-add-border-to-feedbacks
branch
from
bf125c3
to
bd8eda5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Aujourd'hui, les feedbacks Modulix nécessitent une révision de leur UX pour qu'elles soient plus facilement identifiables comme un bloc à part entière.
🤖 Proposition
Ajouter une bordure à gauche des feedbacks en suivant la maquette de Quentin.
🌈 Remarques
J'ai fait différemment de ce qui a été implémenté sur Pix Admin afin de ne pas casser le CSS relatif à la contribution (conserver le BEM de
.feedback__state).💯 Pour tester