[TECH] Renommer le job de l'état shared d'une participation à Pole Emploi pour être ISO par rapport aux autres job (PIX-13938) #9887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
changed the title
xav-car
force-pushed
the
tech-rename-job
branch
from
2420e12
to
00db72a
Compare
xav-car
added
Development in progress
team-prescription
tech-days-evenementiel
xav-car
force-pushed
the
tech-rename-job
branch
2 times, most recently
from
3513ed6
to
5425cdf
Compare
xav-car
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
|
On aurait presque pu en profiter pour les renommer France Travail 😂 |
j'ai renommé les job en participation started / completed / shared . et je pense que c'est plus au usecase. de porter l'informations sur quel context on est ? what do you think ? (j'ai fait un commit en ce sens . mais je peux le revert au besoins ) On peut on peut . ou les rendre générique si on a d'autre demande :) |
xav-car
changed the base branch from
dev
to
tech-jobs-reworks-dependencies-injection
xav-car
force-pushed
the
tech-rename-job
branch
2 times, most recently
from
066abd0
to
457a9cb
Compare
bpetetot
reviewed
Aug 21, 2024
...ion/infrastructure/repositories/jobs/pole-emploi-participation-shared-job-repository_test.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Aug 21, 2024
...tests/prescription/campaign-participation/unit/domain/usecases/share-campaign-result_test.js
Outdated
Show resolved
Hide resolved
bpetetot
approved these changes
Aug 21, 2024
pix-service-auto-merge
force-pushed
the
tech-jobs-reworks-dependencies-injection
branch
from
6d2e286
to
9e880c4
Compare
pix-service-auto-merge
force-pushed
the
tech-jobs-reworks-dependencies-injection
branch
5 times, most recently
from
9727688
to
b137825
Compare
Base automatically changed from
tech-jobs-reworks-dependencies-injection
to
dev
August 21, 2024 14:12
xav-car
force-pushed
the
tech-rename-job
branch
3 times, most recently
from
7998d9e
to
6279afa
Compare
rouxxi
added
Func Review OK
pix-service-auto-merge
force-pushed
the
tech-rename-job
branch
from
6279afa
to
03ecf84
Compare
rouxxi
force-pushed
the
tech-rename-job
branch
from
03ecf84
to
f3325cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Les jobs d'un même context n'ont pas de consistance
🤖 Proposition
Utiliser un nommage consistant pour les évenements PE
🌈 Remarques
Duplication de l'évènement shared afin que les anciens évènements présent entre deux MEP puissent être executé
💯 Pour tester
Vérifier que nous avons bien l'évenement enregistrer dans pgboss