Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Retirer les member actions de Pix Admin (PIX-13946) #9900

Merged
merged 13 commits into from
Sep 12, 2024

Conversation

P-Jeremy
Copy link
Contributor

@P-Jeremy P-Jeremy commented Aug 21, 2024

🦄 Problème

"ember-api-actions" avait été installé afin de contourner l'usage des adapter et d'Ember Data. Mais la solution n'est pas pérenne, il faut maintenir, c'est une douleur et la librairie n'est plus maintenue.

🤖 Proposition

Supprimer la dépendance "ember-api-actions" et utiliser les adapters existants. Concrètement, on n'utilise plus de memberAction, on revient aux adapters.

🌈 Remarques

  • Pour les adapteurs possédant déjà des updateRecord avec un système de if else sur les adapterOptions, nous avons gardé le même fonctionnement:

admin/app/adapters/certification.js
image

  • Pour les adapteurs possédant des méthodes spécifiques, nous avons gardé le même fonctionnement:

admin/app/adapters/target-profile.js
image

  • Certaines memberActions étaient placées dans des modèles qui ne correspondaient pas à la route api appelée, nous les avons mis dans les adapters qui nous paraissaient logiques:

    • Par exemple la méthode pour attacher un target-profile à des organizations faisait appel à une member-action d'organization qui appelait la route : const url = ${this.host}/${this.namespace}/target-profiles/${targetProfileId}/attach-organizations; . Nous l'avons donc retiré du modèle organization pour la placer dans l'adapter target-profile

💯 Pour tester

Vérifier que les tests passent au vert

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch 6 times, most recently from 9e6c744 to 63b7181 Compare August 21, 2024 13:24
@mariannebost mariannebost force-pushed the pix-13946-remove-member-actions-from-admin branch from 63b7181 to ec733b8 Compare August 21, 2024 15:11
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch 3 times, most recently from 80a5596 to 6ba9f83 Compare August 22, 2024 08:04
@Eithliu Eithliu force-pushed the pix-13946-remove-member-actions-from-admin branch from 6ba9f83 to c3c126e Compare August 22, 2024 08:41
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch from c3c126e to 2e50435 Compare August 22, 2024 09:16
@mariannebost mariannebost force-pushed the pix-13946-remove-member-actions-from-admin branch from 2e50435 to b233d7c Compare August 22, 2024 10:03
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch from e5db6cc to e63ad1f Compare August 22, 2024 12:04
@Eithliu Eithliu requested a review from a team as a code owner August 22, 2024 12:57
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch 3 times, most recently from 28b7e9f to 40a3305 Compare August 22, 2024 13:43
@mariannebost mariannebost force-pushed the pix-13946-remove-member-actions-from-admin branch from 40a3305 to 304bc09 Compare August 22, 2024 14:37
@Eithliu Eithliu force-pushed the pix-13946-remove-member-actions-from-admin branch from e0b7d33 to 8a37061 Compare August 22, 2024 15:23
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch from 46262b7 to 8bd9908 Compare August 23, 2024 13:17
@Eithliu Eithliu force-pushed the pix-13946-remove-member-actions-from-admin branch from 8bd9908 to 8623039 Compare August 23, 2024 15:13
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch 2 times, most recently from 4b490a5 to 27be4bb Compare August 26, 2024 07:53
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch from 2db81e0 to d207495 Compare August 29, 2024 08:48
@fael-b
Copy link
Contributor

fael-b commented Aug 29, 2024

Bravo pour ce travail colossal 🥳🔥

@mariannebost mariannebost force-pushed the pix-13946-remove-member-actions-from-admin branch from d207495 to 91e390b Compare August 29, 2024 12:46
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch 2 times, most recently from 4b156f9 to 71b014a Compare August 30, 2024 13:21
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch from 71b014a to 26b3b42 Compare September 12, 2024 09:32
P-Jeremy and others added 13 commits September 12, 2024 11:52
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
…ng model

Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
@P-Jeremy P-Jeremy force-pushed the pix-13946-remove-member-actions-from-admin branch from 26b3b42 to 7dbb95f Compare September 12, 2024 09:52
@pix-service-auto-merge pix-service-auto-merge merged commit 864e535 into dev Sep 12, 2024
12 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-13946-remove-member-actions-from-admin branch September 12, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants