-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Retirer les member actions de Pix Admin (PIX-13946) #9900
Merged
pix-service-auto-merge
merged 13 commits into
dev
from
pix-13946-remove-member-actions-from-admin
Sep 12, 2024
Merged
[TECH] Retirer les member actions de Pix Admin (PIX-13946) #9900
pix-service-auto-merge
merged 13 commits into
dev
from
pix-13946-remove-member-actions-from-admin
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
6 times, most recently
from
August 21, 2024 13:24
9e6c744
to
63b7181
Compare
mariannebost
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 21, 2024 15:11
63b7181
to
ec733b8
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
3 times, most recently
from
August 22, 2024 08:04
80a5596
to
6ba9f83
Compare
Eithliu
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 22, 2024 08:41
6ba9f83
to
c3c126e
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 22, 2024 09:16
c3c126e
to
2e50435
Compare
mariannebost
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 22, 2024 10:03
2e50435
to
b233d7c
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 22, 2024 12:04
e5db6cc
to
e63ad1f
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
3 times, most recently
from
August 22, 2024 13:43
28b7e9f
to
40a3305
Compare
mariannebost
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 22, 2024 14:37
40a3305
to
304bc09
Compare
Eithliu
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 22, 2024 15:23
e0b7d33
to
8a37061
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 23, 2024 13:17
46262b7
to
8bd9908
Compare
Eithliu
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 23, 2024 15:13
8bd9908
to
8623039
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
2 times, most recently
from
August 26, 2024 07:53
4b490a5
to
27be4bb
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 29, 2024 08:48
2db81e0
to
d207495
Compare
Bravo pour ce travail colossal 🥳🔥 |
mariannebost
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
August 29, 2024 12:46
d207495
to
91e390b
Compare
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
2 times, most recently
from
August 30, 2024 13:21
4b156f9
to
71b014a
Compare
mcampourcy
approved these changes
Sep 12, 2024
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
September 12, 2024 09:32
71b014a
to
26b3b42
Compare
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
…ng model Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com> Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com> Co-authored-by: Eithliu <iris.benoit@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Jérémy Pluquet <jemyplu@gmail.com> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
Co-authored-by: Eithliu <iris.benoit@pix.fr> Co-authored-by: Marianne Bost <marianne.bost@pix.fr>
P-Jeremy
force-pushed
the
pix-13946-remove-member-actions-from-admin
branch
from
September 12, 2024 09:52
26b3b42
to
7dbb95f
Compare
mariannebost
approved these changes
Sep 12, 2024
P-Jeremy
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
PO validated functionally the PR
and removed
👀 Tech Review Needed
👀 Func Review Needed
labels
Sep 12, 2024
pix-service-auto-merge
deleted the
pix-13946-remove-member-actions-from-admin
branch
September 12, 2024 10:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cross-team
Toutes les équipes de dev
Func Review OK
PO validated functionally the PR
🚀 Ready to Merge
Tech Review OK
tech-days-pix-admin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
"ember-api-actions" avait été installé afin de contourner l'usage des adapter et d'Ember Data. Mais la solution n'est pas pérenne, il faut maintenir, c'est une douleur et la librairie n'est plus maintenue.
🤖 Proposition
Supprimer la dépendance "ember-api-actions" et utiliser les adapters existants. Concrètement, on n'utilise plus de
memberAction
, on revient auxadapters
.🌈 Remarques
updateRecord
avec un système deif else
sur lesadapterOptions
, nous avons gardé le même fonctionnement:admin/app/adapters/certification.js
admin/app/adapters/target-profile.js
Certaines memberActions étaient placées dans des modèles qui ne correspondaient pas à la route api appelée, nous les avons mis dans les adapters qui nous paraissaient logiques:
target-profile
à des organizations faisait appel à unemember-action
d'organization
qui appelait la route :const url = ${this.host}/${this.namespace}/target-profiles/${targetProfileId}/attach-organizations;
. Nous l'avons donc retiré du modèleorganization
pour la placer dans l'adaptertarget-profile
💯 Pour tester
Vérifier que les tests passent au vert