Revert "Bump codecov/codecov-action from 3 to 4 (#253)" #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 49a65ab. The bump originated from an automated PR from Dependabot triggered by an accidental v4 tag push in the codecov/codecov-action repository. The tag has since been removed due to the v4 major version series of the action still being in the beta development phase. That removal caused subsequent runs of the workflow to fail: Error: Unable to resolve action `codecov/codecov-action@v4`, unable to find version `v4` So the action ref must be reverted back to v3. It can be bumped back to the v4 major version ref following the production 4.0.0 release in the action's repo.
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
aentinger
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 49a65ab.
The bump originated from an automated PR from Dependabot triggered by an accidental
v4tag push in the codecov/codecov-action repository: codecov/codecov-action#1089The tag has since been removed due to the v4 major version series of the action still being in the beta development phase. That removal will cause subsequent runs of the workflow to fail:
So the action ref must be reverted back to
v3. It can be bumped back to thev4major version ref following the production 4.0.0 release in the action's repo.Note: The Codecov upload token is no longer optional in v4 of the action:
https://github.com/107-systems/107-Arduino-Cyphal/actions/runs/6188762056/job/16801442689#step:4:17
so it will be necessary to also adjust the workflow to provide the token to the action at the same time as the bump. Doing so is a good idea anyway because, although supported in v3, the lack of a token was causing periodic spurious coverage data upload failures. That was done already in the Arduino CLI repo (arduino/arduino-cli#2129) and the approach used there has passed the test of time with flying colors.