This repository has been archived by the owner on May 26, 2024. It is now read-only.
Fix: Always have a complete NMEA message in buffer #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… buffer when the start of a valid message is detected.
…fer starts with '$'
aentinger
added
type: enhancement
…sing struct ParserBuffer.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 91.30% 91.57% +0.27%
==========================================
Files 10 10
Lines 368 380 +12
==========================================
+ Hits 336 348 +12
Misses 32 32
Continue to review full report at Codecov.
|
|
Memory usage change @ 4293c36
Click for full report table
Click for full report CSV |
…as suffered from the fact that it did not check for the occurence of both $ and \r\n within the parser buffer. Consequently - when during a power down an incomplete message arrives garbage is fed to the decoder which leads to all sorts of trouble down the line. This commit is fixing this issue.
aentinger
force-pushed
the
fix-always-complete-message-in-parse-buffer
branch
from
4855ab1 to
5173234
Compare
|
Memory usage change @ 5173234
Click for full report table
Click for full report CSV |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #31.