Custom time_frame must be JSON body NOT parameter key value #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No where does it say time_frame is a post body object rather than key pair, this actually will NOT run as url parameter. Please take note this is poor consistency as filter DOES accept JSON via key-value param, so there is an expectation time_frame (also technically a filter, should too).
Response received when running as parameter
{
"message": "{\n \"time_frame\": {\n \"from\": \"2020-01-01\",\n \"to\": \"2024-12-31\"\n }\n} is not a valid time_frame"
}
|
@tithonium wanted to check in on this documentation update, any questions or issues with merging it in? I have more coming as I just discovered an issue with time_frame ignoring custom and defaulting to this week when submitting via form (or whatever bridge parameters send as) vs url param which allows the json body to be read and respected. |
Get Custom fields documentation disregarded the required namespace parameter Updating a namespaces custom field on a record does was ambiguous with the field <id>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No where does it say time_frame is a post body object rather than key pair, this actually will NOT run as url parameter. Please take note this is poor consistency as filter DOES accept JSON via key-value param, so there is an expectation time_frame (also technically a filter, should too).
Response received when running as parameter
{
"message": "{\n "time_frame": {\n "from": "2020-01-01",\n "to": "2024-12-31"\n }\n} is not a valid time_frame"
}