BUG: Index cleanup process - offset being zeroed too late

[pknap]

I think that in indexer cleanup process (I am testing it with 4.7.2 version), offset resetting happens too late here:

ElasticPress/includes/classes/IndexHelper.php

Line 845 in 1844e31

$this->index_meta['offset'] = 0;

In case there are any errors during one indexable type indexing (in my case full reindex called from admin dashboard) it will try to output warning before resetting offset.

The problem is, that output method in the end calls wp_send_json which calls die() / wp_die() and effectively stops further execution. This means that offset will not be zeroed.

Then, when next indexable type indexing starts it picks up offset from where previous indexing finished. So for example when I had 1465 posts to index, terms will start indexing from offset 1465, which in my case leads to terms index being empty.

I believe that offset reset should be moved upper, probably right after $this->index_meta['current_sync_item'] = null;