moved index offset reset before message output in indexer cleanup process #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pknap, do you mind fixing the lint issue in 825 so we can merge this PR? (It should be just a matter of aligning the equal sign with line 824.) Thanks! |
pknap
force-pushed
the
fix/3764-move-offset-reset-before-message-output-in-indexer-cleanup
branch
from
9893d01
to
655013e
Compare
Hi @felipeelia sure thing, should be done now. |
…-output-in-indexer-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Closes #3764
How to test the Change
Run full reindex with multiple indexables when first indexable returns warnings. It should still index further indexables properly.
Before:
After:
Changelog Entry
Credits
@pknap
Checklist: