Added action_set_object_terms #1969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Queues posts for re-indexing when their terms are changed
|
Using this approach https://www.elastic.co/guide/en/elasticsearch/guide/current/partial-updates.html we should update just the taxonomy field that changes with a bulk update. |
6 tasks
|
@rebeccahum Curious for your thoughts on the approach suggested above as I know VIP has some potential customers with large term sets. cc @brandon-m-skinner @rinatkhaziev |
rebeccahum
suggested changes
Dec 15, 2021
| * @since 3.5 | ||
| */ | ||
| public function action_set_object_terms( $object_id, $terms, $tt_ids, $taxonomy, $append, $old_tt_ids ) { | ||
| $post_id = $object_id; |
There was a problem hiding this comment.
Missing a check for $this->kill_sync():
Suggested change
| $post_id = $object_id; | |
| if ( $this->kill_sync() ) { | |
| return; | |
| } | |
| $post_id = $object_id; |
| public function action_set_object_terms( $object_id, $terms, $tt_ids, $taxonomy, $append, $old_tt_ids ) { | ||
| $post_id = $object_id; | ||
|
|
||
| $indexable = Indexables::factory()->get( 'post' ); |
There was a problem hiding this comment.
For code consistency, let's use $this->indexable_slug even though it will end up evaluating to post:
Suggested change
| $indexable = Indexables::factory()->get( 'post' ); | |
| $indexable = Indexables::factory()->get( $this->indexable_slug ); |
| // Bypass saving if doing autosave | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
We should add a filter for skipping a sync triggered by term changes
|
This also closes #750 |
|
Closing in favor of #2603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Queues posts for re-indexing when their terms are changed.
Props @nickdaugherty
cc: @rinatkhaziev @pschoffer @netsuso @parkcityj
Alternate Designs
N/A
Benefits
Post data remains consistent with the database which keeps queries returning expected results.
Possible Drawbacks
The default behaviour is problematic when there are a lot of posts. We only do this behaviour for 10k or less posts and offload any indexing with counts above that to be processed asynchronously.
Verification Process
We noticed data inconsistencies when comparing posts from the DB against posts from ES when editing terms. After applying these changes, the index and the DB were consistent.
Checklist:
Applicable Issues
Changelog Entry
Added queuing of affected posts on term change. Props @nickdaugherty