Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set index in lowercase #2173

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Set index in lowercase #2173

merged 1 commit into from
Apr 30, 2021

Conversation

teoteo
Copy link
Contributor

@teoteo teoteo commented Apr 16, 2021

Description of the Change

The index_name is transformed in lowercase before the index creation in Elasticsearch.
Change suggested by @felipeelia #2166 (comment)

Alternate Designs

Benefits

Uppercase text in Elasticsearch aren’t allowed so this fix transforms the index name in lowercase before creating an index

Possible Drawbacks

Verification Process

  1. Installed WordPress an uppercase folder so the baseurl was: https://elasticpress.test/UPPERCASE_FOLDER ;
  2. installed ElasticPress plugin and activated;
  3. configured ElasticPress to a self hosted Elasticsearch server;
  4. syncronized -> failed to create index;
  5. applied the fix;
  6. syncronized -> index created;
  7. created some contents: they are searchable and the index health page is OK

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes: #2166

Changelog Entry

Fixed issue with uppercase in siteurl

Copy link
Contributor

@Rahmon Rahmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandwaffle brandwaffle merged commit 39edf52 into 10up:develop Apr 30, 2021
@felipeelia felipeelia added this to the 3.6.0 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Index creation failure if the siteurl contains uppercase characters
4 participants