Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post__name_in support #2194

Merged
merged 7 commits into from
May 21, 2021
Merged

Add post__name_in support #2194

merged 7 commits into from
May 21, 2021

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

Hi @felipeelia , can you please review this PR implementing #1519 (comment) ?

Alternate Designs

Benefits

Adds support for post__name_in

Possible Drawbacks

Verification Process

  • Unit tests
  • Tested it worked with a normal WP_Query object and using the pre_get_posts hook

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

@oscarssanchez oscarssanchez requested a review from Rahmon May 13, 2021 22:22
Rahmon
Rahmon suggested changes May 18, 2021
View reviewed changes
tests/php/indexables/TestPost.php Outdated Show resolved Hide resolved
@Rahmon Rahmon assigned oscarssanchez and unassigned Rahmon May 18, 2021
Rahmon
Rahmon approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@Rahmon Rahmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brandwaffle brandwaffle merged commit 1a99301 into develop May 21, 2021
@brandwaffle brandwaffle deleted the feature/post__name_in-support branch May 21, 2021 14:45
@felipeelia felipeelia added this to the 3.6.0 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rahmon Rahmon Rahmon approved these changes

@felipeelia felipeelia felipeelia approved these changes

Assignees

@Rahmon Rahmon

Labels
high priority
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oscarssanchez @felipeelia @Rahmon @brandwaffle @mckdemps