Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Elasticsearch::get_documents and Indexable::multi_get #2210

Merged
merged 13 commits into from
May 28, 2021

Conversation

felipeelia
Copy link
Member

Description of the Change

This is a "take over" of #1959

We needed an easy way to fetch multiple documents per API call, so we added get_documents to the Elasticsearch class and then added multi_get to the Indexable class for ease of use.

Props @nickdaugherty
cc: @rinatkhaziev @pschoffer @netsuso @parkcityj

Alternate Designs

N/A

Benefits

Allows you to get multiple documents per API call.

Possible Drawbacks

N/A

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Changelog Entry

Added Elasticsearch::get_documents and Indexable::multi_get. Props @nickdaugherty and @felipeelia

@Rahmon Rahmon assigned felipeelia and unassigned Rahmon May 21, 2021
@felipeelia felipeelia assigned Rahmon and unassigned felipeelia May 21, 2021
@Rahmon Rahmon assigned felipeelia and unassigned Rahmon May 24, 2021
Rahmon
Rahmon previously approved these changes May 24, 2021
Copy link
Contributor

@Rahmon Rahmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@felipeelia
Copy link
Member Author

@oscarssanchez as all tests have passed, can you please give this a final review and merge it? Thanks!

@oscarssanchez oscarssanchez merged commit de9d2ae into develop May 28, 2021
@oscarssanchez oscarssanchez deleted the add/get_documents branch May 28, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants