Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget to search only on comments #2238

Merged
merged 31 commits into from
Jun 30, 2021
Merged

Widget to search only on comments #2238

merged 31 commits into from
Jun 30, 2021

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Jun 24, 2021

Description of the Change

This change adds a widget to search for comments since PR #1531 adds a Comments Indexable.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

  1. Enable Comments Feature
  2. Add the widget ElasticPress - Comments
  3. Search for a comment

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Closes #2177

Changelog Entry

Added ElasticPress - Comments widget

@Rahmon Rahmon added this to the 3.6.0 milestone Jun 24, 2021
@Rahmon Rahmon requested a review from felipeelia June 24, 2021 12:55
felipeelia
felipeelia requested changes Jun 28, 2021
View reviewed changes
assets/css/comments.css
}

.ep-widget-search-comments-result-item.selected a {
border: 2px dotted #171923;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rahmon you made me curious about this line here. Any reason why did you pick this color? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felipeelia I've chosen this color to not use pure black but we can change it.

assets/js/comments.js Outdated Show resolved Hide resolved
assets/js/comments.js Show resolved Hide resolved
assets/js/comments.js Outdated Show resolved Hide resolved
includes/classes/Feature/Comments/Comments.php Outdated Show resolved Hide resolved
includes/classes/Feature/Comments/Widget.php Outdated Show resolved Hide resolved
includes/classes/Feature/Comments/Widget.php Outdated Show resolved Hide resolved
includes/classes/Feature/Comments/Widget.php Outdated Show resolved Hide resolved
includes/classes/Feature/Comments/Widget.php Show resolved Hide resolved
includes/classes/Feature/Comments/Widget.php Outdated Show resolved Hide resolved
@felipeelia felipeelia assigned Rahmon and unassigned felipeelia Jun 28, 2021
felipeelia
felipeelia requested changes Jun 29, 2021
View reviewed changes
includes/classes/Feature/Comments/Comments.php Outdated Show resolved Hide resolved
includes/classes/Feature/Comments/Widget.php Outdated Show resolved Hide resolved
@Rahmon Rahmon removed their assignment Jun 29, 2021
@Rahmon Rahmon requested a review from felipeelia June 29, 2021 14:48
@Rahmon Rahmon merged commit 291216b into develop Jun 30, 2021
@Rahmon Rahmon deleted the feature/widget-search-comments-issue-2177 branch June 30, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia approved these changes

Assignees

@felipeelia felipeelia

Labels
high priority
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Widget to search only on comments
2 participants
@Rahmon @felipeelia