Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labels and title attributes to icon hyperlinks in the header toolbar #2304

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Add aria-labels and title attributes to icon hyperlinks in the header toolbar #2304

merged 3 commits into from
Aug 16, 2021

Conversation

claytoncollie
Copy link
Contributor

Description of the Change

Issue #2286

Alternate Designs

This was the least intrusive option. The second option would be tooltips on each icon which would require additional javascript. The third option would be to add a text label just below the icon which probably involves some sort of design change and sign-off.

Benefits

  1. Screen readers will be able to identify the links
  2. New users will understand the icon's function before selecting it

Verification Process

To verify, I went to the wp-admin dashboard for the plugin and hovered over each icon to see the title attribute.

Also ran composer run lint-fix in my editor to make sure my code formatting was correct.

Checklist:

  • [X ] I have read the CONTRIBUTING document.
  • [ X] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Add title attributes and aria-labels to each icon hyperlink in the header toolbar

includes/partials/header.php Outdated Show resolved Hide resolved
@felipeelia felipeelia merged commit ba89c99 into 10up:develop Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants