WP Acceptance Fixes #2352
Merged
WP Acceptance Fixes #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix in WPA test the typo fixed in #2336
felipeelia
changed the title
Rahmon
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
1. Widget screen and "are you sure..." error
In the Widgets Edit Screen, it seems sometimes WP keeps a dirty state even after a successful save. When that happens, we get stuck with a "Are you sure you want to leave...?" message, and tests fail due to a timeout. Clicking on the "Update" button again seems to fix the issue.
2. Typo in WP-CLI Command
In #2336 a typo was fixed but the WPA test is still checking for the wrong string.
3. New
moveTo()methodThis PR adds a new
moveTo()method to theTestBaseclass. Using this method, instead of relying on the usualActor::moveTo()will make the test suite retry to access the page until it succeeds or fails with any error other thanPage crashed.Applicable Issues
Closes #2351
Changelog Entry