Index anonymous/guest comments, fixes #2356 #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm unsure if the capability checks are necessary at all, after all if a comment has been deleted surely the checks must have happened beforehand? Even still, this also leaves the open question of meta. E.g. what if the user can't do these things, but it's being done via a hook in code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This attempts to fix broken indexing of anonymous/guest comments
I'm unsure if the capability checks are necessary at all, after all if a comment has been deleted surely the checks must have happened beforehand?
Even still, this also leaves the open question of meta. E.g. what if the user can't do these things, but it's being done via a hook in code?
Benefits
Fixes a bug
Possible Drawbacks
Not merging and not fixing the bug
Verification Process
I haven't yet, this is a very long template to fill out
Checklist:
Applicable Issues
#2356
Changelog Entry