Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force fetching ep_wpcli_sync_interrupted transient from remote to allow for more reliable remote interruption #2433

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Nov 2, 2021

Description of the Change

During some testing, it was discovered that wp elasticpress stop-indexing doesn't reliably terminate the execution of an already-running process.

I think this is due to the cache value being stuck in local memory, this should help to prevent that by always forcing the remote fetch from the object cache backend.

Props @rinatkhaziev for Automattic#108

Alternate Designs

N/A

Benefits

The command will be more reliable in terminating the execution of an already-running process.

Possible Drawbacks

None I can think of.

Verification Process

  1. Check out PR.
  2. Spin up an indexing process in a memcached-enabled environment
  3. Run wp elasticpress stop-indexing from another session
  4. Repeat the process and verify it gets interrupted properly.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed: Force fetching ep_wpcli_sync_interrupted transient from remote to allow for more reliable remote interruption

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants