Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR refactors the dashboard script and adjusts the markup to:
<form>
to take advantage of form APIs to simplify the script and markup, and improve keyboard accessibility.It does not adjust the JavaScript for the ElasticPress > Settings page, so that has been moved into a separate file.
Benefits
Improves keyboard accessibility, by things such as allowing submitting the forms with the Enter key. It also simplifies the code so that it does not depend on custom data attributes and form handling.
Possible Drawbacks
Not necessarily a drawback, but the change results in a visual change for the Learn more and Collapse buttons:
Verification Process
Go to ElasticPress > Features and adjust settings of all features and verify that they are saving correctly. Also check ElasicPress > Settings and verify that it functions as expected.
Checklist:
Applicable Issues
Closes #2496
Changelog Entry