Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n to index start and end date format #2548

Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Jan 11, 2022

Description of the Change

This PR adds i18n to index start and end date format.

Alternate Designs

Benefits

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#2489

Changelog Entry

@felipeelia
Copy link
Member

Sorry, @Rahmon, I guess I should've been clearer in my comment before. What I meant is that we should have this value stored in the index_meta as something that could be translated at a later point in the process. So, let's say we only store a timestamp or a datetime format (YYYY-MM-DD HH:mm:ss). So, just when outputting it here we'd translate it.
As is now, if an Italian user starts the sync, a Brazilian user won't have a way to receive the info in a properly translated string. Thoughts?

@felipeelia felipeelia assigned Rahmon and unassigned felipeelia Jan 11, 2022
@Rahmon Rahmon assigned felipeelia and unassigned Rahmon Jan 17, 2022
@Rahmon
Copy link
Contributor Author

Rahmon commented Jan 17, 2022

@felipeelia I've updated to store the date in ISO-8601 format and made the date translatable in JavaScript. Could you review it again?

@felipeelia felipeelia merged commit 86c9e86 into 4.x.x Jan 17, 2022
@felipeelia felipeelia deleted the chore/add-i18n-index-start-end-date-format-issue-2489 branch January 17, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants