-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/facets tax query #2560
Merged
Merged
Fix/facets tax query #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarssanchez
requested review from
felipeelia
and removed request for
Rahmon
January 19, 2022 15:56
@oscarssanchez talked to @brandwaffle about this one and it would probably be better to change our "filter_" to "ep_filter_", so we avoid any future conflict that may arise. Obviously, that would be a filterable string, so people could go back to "filter_" if they want. What do you think? |
Assigning for review @felipeelia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes #2502 by checking if we have a pre existing tax query done by external code (in this case, the Woocommerce brands plugin). If we do, there's no need to add another tax query with EP if using facets.
Alternate Designs
Possible Drawbacks
Verification Process
1.- Have some brands and products associated with them
2.- Have a layared brand nav widget set
3.- Select one of the brands in the widget in the frontend
4.- Associated products should appear
Checklist:
Changelog Entry
Credits
Props @