Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/facets tax query #2560

Merged
merged 12 commits into from
Feb 22, 2022
Merged

Fix/facets tax query #2560

merged 12 commits into from
Feb 22, 2022

Conversation

oscarssanchez
Copy link
Contributor

Description of the Change

This PR fixes #2502 by checking if we have a pre existing tax query done by external code (in this case, the Woocommerce brands plugin). If we do, there's no need to add another tax query with EP if using facets.

Alternate Designs

Possible Drawbacks

Verification Process

1.- Have some brands and products associated with them
2.- Have a layared brand nav widget set
3.- Select one of the brands in the widget in the frontend
4.- Associated products should appear

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@oscarssanchez oscarssanchez self-assigned this Jan 18, 2022
@oscarssanchez oscarssanchez requested review from felipeelia and removed request for Rahmon January 19, 2022 15:56
@oscarssanchez oscarssanchez removed their assignment Jan 19, 2022
@mckdemps mckdemps modified the milestones: 4.0.0, 4.0.0 (beta 2) Jan 25, 2022
@felipeelia
Copy link
Member

@oscarssanchez talked to @brandwaffle about this one and it would probably be better to change our "filter_" to "ep_filter_", so we avoid any future conflict that may arise. Obviously, that would be a filterable string, so people could go back to "filter_" if they want. What do you think?

@oscarssanchez
Copy link
Contributor Author

Assigning for review @felipeelia

@felipeelia felipeelia changed the base branch from develop to 4.x.x February 22, 2022 14:21
@felipeelia felipeelia merged commit 3df3d0c into 4.x.x Feb 22, 2022
@felipeelia felipeelia deleted the fix/facets-tax-query branch February 22, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Incompatibility with WooCommerce Brands
3 participants