Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show WP-CLI progress on sync page #2564

Merged
merged 7 commits into from
Feb 4, 2022

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Jan 21, 2022

Description of the Change

#2489

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@Rahmon Rahmon added the bug Something isn't working label Jan 21, 2022
@Rahmon
Copy link
Contributor Author

Rahmon commented Jan 21, 2022

@felipeelia This PR changes the code to show the WP-CLI sync progress on the Sync page, however, it's necessary to handle the case when the WP-CLI sync is interrupted by Ctrl + C (for example). Currently, there is no difference compared to when the sync is finished. It's necessary to send a different response from AJAX to be possible to know when the sync finished or was interrupted.

Other than that, it's not possible to stop the WP-CLI from the Sync page. Maybe this case could be done in another PR.

@mckdemps mckdemps modified the milestones: 4.0.0, 4.0.0 (beta 2) Jan 25, 2022
@felipeelia felipeelia merged commit 4080ea1 into 4.x.x Feb 4, 2022
@felipeelia felipeelia deleted the fix/wp-cli-progress-on-sync-page-issue-2489 branch February 4, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants