Fix product visibility evaluation in PHP 8 #2566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently, InstantResults::apply_product_visibility() calls
wc_get_product_visibility_term_ids()
and uses$product_visibility_terms['exclude-from-search']
as an array, when it actually is a term id. In PHP 8, that results in a fatal error:This PR addresses that, forcing the result to be an array.
Verification Process
Changelog Entry
Fixed the sync page when WC's "hide out of stock items" and Instant Results are both enabled.