Refactor backend JS to remove jQuery dependency #2664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR refactors the JavaScript for the Settings, Weighting, and Network Sites screens, as well as the JavaScript for handling admin notice dismissals, to remove jQuery as a dependency. It also fixes the occasional bug in the original scripts.
For the ElasticPress indexing switches in the Network Sites screen I took this as an opportunity to replaced the custom switch with the core WordPress toggle control for more consistency with the WordPress UI and better accessibility and handling of a busy state to avoid race conditions I encountered with rapid switching.
Closes #2074
Verification Process
For the Settings screen, verify that:
For the Weighting screen, verify that:
For the Network Sites screen, verify that:
For admin notices, verify that:
Checklist:
Changelog Entry
Credits
Props @JakePT