Add support for multiple aggregations #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarssanchez
requested changes
Mar 28, 2022
| $formatted_args['aggs'][ $agg_name ]['aggs'] = $agg_obj['aggs']; | ||
| if ( isset( $args['aggs'] ) ) { | ||
| // An array of aggregations. | ||
| if ( isset( $args['aggs'][0] ) ) { |
There was a problem hiding this comment.
Would it be better to check if this is an array with is_array() ? Right now I don't think it would do any harm, but i'm thinking if there's ever a case where we offer an aggregations filter for example, and people can manipulate the array indexes. If there's not $args['aggs'][0] but there's $args['aggs'][1] this code will not run.
There was a problem hiding this comment.
I've made the changes we discussed in slack @oscarssanchez . Do you mind giving yet another look at it? Thanks!
oscarssanchez
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Currently, the plugin only supports a single array as the
aggsparameter of WP_Query. This PR changes that to also support an array of aggregations. This will be needed to implement #1440 in a cleaner way.Closes #636
Changelog Entry
Added: Support for an array of aggregations in the
aggsparameter of WP_Query.Credits
Props @felipeelia