Preserve existing URL parameters in history. #2777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes an issue where any existing non-ElasticPress URL parameters would be cleared when using Instant Results, and an additional side effect where parameters would be removed when page was refreshed while Instant Results was activated, even if it wasn't actively being used at the time.
Previously when Instant Results updated the browser history state it would replace all URL parameters with Instant Results parameters, and when Instant Results was closed all of those parameters would be cleared, leaving none.
This PR changes it so that any URLs present in the URL when a page is loaded are preserved throughout the course of using Instant Results, which also fixes the refresh issue.
Closes #2775.
Verification Process
Navigating backwards and forwards through the Instant Results history should work as before, but the issue described in #2775 should not occur.
Checklist:
Changelog Entry
Fixed - A bug where URL search parameters could be cleared when using Instant Results.
Credits
Props @JakePT