Change sync button title attribute #2814
Conversation
|
@burhandodhy instead of simply "Sync", let's say "Sync Page" (and "Settings Page".) |
1 similar comment
|
@burhandodhy instead of simply "Sync", let's say "Sync Page" (and "Settings Page".) |
| describe('Settings Page', () => { | ||
| it('Can see a Sync and Settings buttons on Settings Page', () => { | ||
| cy.visitAdminPage('admin.php?page=elasticpress-settings'); | ||
| cy.get('.dashicons.start-sync').should('have.attr', 'title', 'Sync Page'); | ||
| cy.get('.dashicons.dashicons-admin-generic').should('have.attr', 'title', 'Settings Page'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
It is GREAT to see tests like these coming through, @burhandodhy, congrats, and thanks! Can we please move it from a whole new test to the already existent general.spec.js? The links should be on all (or almost all) pages, so although it makes sense to pick one to check, we can save a settings-page.spec.js to something particular to that page, like checking if tabs change, etc. What do you think?
There was a problem hiding this comment.
@felipeelia agree with you. settings-page.spec.js should only have tests that are related to settings page. I move the test to general.spec.js
Description of the Change
This PR changes the Sync button title attribute to
Sync Pageand Settings button title toSettings Pageand also add the E2E test.Closes #2793
Verification Process
SyncChangelog Entry
Changed: Sync button Title.
Credits
Props @burhandodhy @JakePT