Restrict to convert meta value into date if year is greater than 2099 #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Jun 7, 2022
felipeelia
requested changes
Jun 13, 2022
includes/classes/Indexable.php
Outdated
Comment on lines
726
to
735
| /** | ||
| * Filter the maximum year limit for date conversion. | ||
| * | ||
| * @hook ep_max_year_limit | ||
| * @param {int} $year Maximum year limit. | ||
| * @return {int} Maximum year limit. | ||
| */ | ||
| // Use default date if year is greater than max limit. EP has limitation that doesn't allow to have year greater than 2099. | ||
| // @see https://github.com/10up/ElasticPress/issues/2769 | ||
| $max_year = apply_filters( 'ep_max_year_limit', 2099 ); |
There was a problem hiding this comment.
This is looking better @burhandodhy, thanks. Some changes are still needed though.
- The
Use default...text and the@seetag should be part of the "docblock", i.e., instead of having//in front of them, they should be part of the comment with/**. Here is an example of a docblock with an additional comment. - Can you please add a
@sincetag with4.2.1?
Thanks!
There was a problem hiding this comment.
Thanks for pointing out the mistake. Feeback is addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
prepare_date_meta_valuesconverts the meta into date even they are not. This PR adds the restriction that will check that if the meta year is greater than 2099 than don't convert intodatetimeformatCloses #2769
Changelog Entry
Fixed: Meta values that are not date are converted into date format
Credits
Props @burhandodhy