Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for instant results feature #2851

Merged
merged 25 commits into from
Sep 20, 2022
Merged

Add tests for instant results feature #2851

merged 25 commits into from
Sep 20, 2022

Conversation

MARQAS
Copy link
Contributor

@MARQAS MARQAS commented Jun 21, 2022

Description of the Change

This PR adds the cypress test for the Instant results feature.

Closes #

Alternate Designs

Possible Drawbacks

Verification Process

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Added: Test for instant results feature.

Credits

Props @MARQAS

@MARQAS MARQAS self-assigned this Jun 21, 2022
@MARQAS MARQAS requested a review from felipeelia June 21, 2022 17:34
@MARQAS MARQAS marked this pull request as ready for review August 23, 2022 08:29
@MARQAS MARQAS assigned MARQAS and felipeelia and unassigned MARQAS Aug 23, 2022
@MARQAS MARQAS added this to the 4.3.0 milestone Aug 23, 2022
@MARQAS MARQAS added enhancement module:instant-results Issues related to the Instant Results functionality labels Aug 23, 2022
Copy link
Member

@felipeelia felipeelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MARQAS, having in mind that we don't need small atomic tests we can merge all the following tests in just one:

Can see instant results list
Can display the number of results
Can show the modal in the same state after a reload
Can update the results after changing the search term

I am not 100% sure about the reason why it is failing on EP.io but it is probably a timeout. Can you try capturing the AJAX request and waiting for it to be completed before checking if "Blog" is visible?

@felipeelia felipeelia assigned MARQAS and unassigned felipeelia Aug 24, 2022
@MARQAS MARQAS assigned felipeelia and unassigned MARQAS Aug 25, 2022
@felipeelia felipeelia modified the milestones: 4.3.0, 4.4.0 Aug 29, 2022
@felipeelia felipeelia assigned MARQAS and JakePT and unassigned felipeelia Sep 16, 2022
@felipeelia felipeelia modified the milestones: 4.4.0, 4.3.1 Sep 19, 2022
@felipeelia felipeelia merged commit 5afa20d into develop Sep 20, 2022
@felipeelia felipeelia deleted the fix/issue-2788 branch September 20, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:instant-results Issues related to the Instant Results functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants