Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: recreate-network-alias throw error on single site #2906

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Fix: recreate-network-alias throw error on single site #2906

merged 2 commits into from
Jul 26, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR adds the check that will check throw the error message if EP is not activated on the network

Closes #2868

How to test the Change

  • Run wp elasticpress recreate-network-alias command on single site.
  • Command should throw the error message ElasticPress is not activated on network..

Changelog Entry

Fixed - recreate-network-alias CLI command returns an error without explanation on single site

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy self-assigned this Jul 26, 2022
@felipeelia felipeelia added this to the 4.3.0 milestone Jul 26, 2022
@felipeelia felipeelia self-requested a review July 26, 2022 14:14
felipeelia
felipeelia requested changes Jul 26, 2022
View reviewed changes
tests/cypress/integration/wp-cli.spec.js Outdated Show resolved Hide resolved
includes/classes/Command.php Outdated Show resolved Hide resolved
@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Jul 26, 2022
@felipeelia felipeelia self-requested a review July 26, 2022 16:31
@felipeelia felipeelia merged commit ff23083 into develop Jul 26, 2022
@felipeelia felipeelia deleted the burhan/fix-2868 branch July 26, 2022 16:56
@burhandodhy burhandodhy restored the burhan/fix-2868 branch August 10, 2022 10:49
@burhandodhy burhandodhy deleted the burhan/fix-2868 branch August 10, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia Awaiting requested review from felipeelia

Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

BUG: recreate-network-alias CLI command returns an error without explanation on single site installs
2 participants
@burhandodhy @felipeelia