Fix incorrect sync being triggered by URL parameter. #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes an issue introduced by #2858 where the do_index parameter was triggering the incorrect sync.
I've also updated URL parameters and inline documentation to make it clearer what's going on and de-couple the meaning of the 'isDeleting' state from the 'putMapping' action which in some cases were using the same variable and parameter names despite being separate concepts.
Lastly I updated the existing tests that were checking that a sync was performed on feature activation to also check that mapping is being sent for those syncs, as that would've caught this issue.
Closes #2938
How to test the Change
When activating a feature that requires a sync the sync should occur int the Delete All Data and Sync panel and the log should show "Mapping sent".
Checklist: