Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check PHP compatibility while linting + PR annotations #2945

Merged
merged 6 commits into from
Aug 12, 2022

Conversation

felipeelia
Copy link
Member

Description of the Change

Following what has been done in some other 10up projects, this PR checks for PHP compatibility while checking for the regular code standard. This also uses the phpcs-action so PHP linting problems become annotations in the PR.

Changelog Entry

Changed - PHP compatibility check merged to regular lint

Credits

Props @felipeelia

@felipeelia felipeelia added this to the 4.3.0 milestone Aug 12, 2022
@felipeelia felipeelia self-assigned this Aug 12, 2022
@felipeelia felipeelia merged commit 1d0dde0 into develop Aug 12, 2022
@felipeelia felipeelia deleted the tests/phpcs-unified-call branch August 12, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant