Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index posts after Woocommerce custom sort #2965

Merged
merged 9 commits into from
Nov 7, 2022
Merged

Index posts after Woocommerce custom sort #2965

merged 9 commits into from
Nov 7, 2022

Conversation

MARQAS
Copy link
Contributor

@MARQAS MARQAS commented Aug 24, 2022

Description of the Change

This PR will resolve the WooCommerce custom sort while using EP

Closes #2928

How to test the Change

  • With Woocommerce and EP enabled, go to Products
  • Click on "sorting"
  • Reorder your products and reload
  • See the ordering has been applied
  • Visit the shop page and see the ordering is applied

Changelog Entry

Fixed - Woocommerce custom sort

Credits

Props @MARQAS, @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@MARQAS MARQAS self-assigned this Aug 24, 2022
@MARQAS MARQAS added this to the 4.4.0 milestone Aug 25, 2022
@MARQAS MARQAS marked this pull request as ready for review August 30, 2022 14:21
@MARQAS MARQAS assigned felipeelia and unassigned MARQAS Aug 30, 2022
@felipeelia felipeelia changed the title Index posts after Woocommerce custom sort [WIP] Index posts after Woocommerce custom sort Sep 8, 2022
@felipeelia
Copy link
Member

felipeelia commented Oct 12, 2022

This PR now needs some e2e tests:

  1. If Content Items per Index Cycle is greater than the number of products, the reorder should trigger a reindex, and reloading the screen should display the correct (new) order
  2. If Content Items per Index Cycle is lower than the number of products, the reorder should NOT trigger a reindex, and a notice indicating the need for a resync should be displayed.

@felipeelia felipeelia removed their assignment Oct 12, 2022
@felipeelia
Copy link
Member

Let's change the text to Due to the number of products in the site, you will need to <a href="%s">resync</a> after applying a custom sort order.

tests/cypress/integration/features/woocommerce.cy.js Outdated Show resolved Hide resolved
tests/cypress/integration/features/woocommerce.cy.js Outdated Show resolved Hide resolved
tests/cypress/integration/features/woocommerce.cy.js Outdated Show resolved Hide resolved
tests/cypress/integration/features/woocommerce.cy.js Outdated Show resolved Hide resolved
@felipeelia felipeelia changed the title [WIP] Index posts after Woocommerce custom sort Index posts after Woocommerce custom sort Nov 7, 2022
@felipeelia felipeelia merged commit ce6f373 into develop Nov 7, 2022
@felipeelia felipeelia deleted the fix/2928 branch November 7, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Woocommerce custom sort doesn't seem to integrate with EP
2 participants