Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings screen improvements #2976

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Settings screen improvements #2976

merged 7 commits into from
Nov 9, 2022

Conversation

MARQAS
Copy link
Contributor

@MARQAS MARQAS commented Sep 2, 2022

Description of the Change

This PR will merge the subscription name and id into one option along with some alignment improvements

Closes #2739

How to test the Change

  • Go to ElasticPress settings screen Dashboard
  • Notice that the Subscription ID and Username are merged into one option
  • Observe the proper alignment of options

Changelog Entry

Changed - Settings screen options

Credits

Props @MARQAS

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.3.1 milestone Sep 19, 2022
@felipeelia
Copy link
Member

@MARQAS after the changes introduced in #3018, this PR needs some refresh. Do you mind taking care of it and letting me know? Thanks!

@felipeelia felipeelia assigned MARQAS and unassigned felipeelia Oct 12, 2022
@felipeelia felipeelia merged commit 9e53302 into develop Nov 9, 2022
@felipeelia felipeelia deleted the feature/2739 branch November 9, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the Settings Config Screen
2 participants