Migrate Autosuggest filters to proper WordPress hooks #2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakePT
added
needs documentation
module:autosuggest
JakePT
commented
Sep 5, 2022
JakePT
commented
Sep 5, 2022
JakePT
changed the title
JakePT
changed the title
felipeelia
requested changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Migrates the custom 'filter' functions in Autosuggest to use proper WordPress hooks. Existing uses of filter functions are applied as callbacks to the new hooks from a back-compat file.
Closes #2961
How to test the Change
Changelog Entry
ep.Autosuggest.itemHTML,ep.Autosuggest.listHTML,ep.Autosuggest.query, andep.Autosuggest.elementJavaScript hooks to Autosuggest and migrated filter functions to hook callbacks for backwards compatibility.Credits
Props @JakePT
Checklist: