Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Term search in admin panel for non-public taxonomies #2988

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

burhandodhy
Copy link
Contributor

@burhandodhy burhandodhy commented Sep 6, 2022

Description of the Change

This PR fixes the issue where the search term in the admin panel returns nothing for the non-public taxonomies. The root cause of the problem is that ElasticPress doesn't sync any non-public taxonomies whether the protected content feature is enabled or not. But when a user searches for the term, EP tries to get the data from ElasticSearh.

My fix added an additional check that will check if all the taxonomies in the query are indexable. If not, then EP will not try to fetch the data from ElasticSearch. 

Closes #2930

How to test the Change

  1. Enable Terms Feature
  2. Create new taxonomy and set the public parameter to false
  3. Create a new term
  4. Search for term in admin dashboard.

Changelog Entry

Fixed - Term search in the admin panel for non-public taxonomies returns nothing.

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy added this to the 4.4.0 milestone Sep 6, 2022
@felipeelia felipeelia modified the milestones: 4.4.0, 4.3.1 Sep 19, 2022
@felipeelia felipeelia merged commit 89370ba into develop Sep 22, 2022
@felipeelia felipeelia deleted the burhan/fix-2930 branch September 22, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Term search returns nothing in the admin panel.
3 participants