Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update order_by_selected method visibility #3009

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Update order_by_selected method visibility #3009

merged 1 commit into from
Oct 11, 2022

Conversation

burhandodhy
Copy link
Contributor

Description of the Change

This PR updaes the order_by_selected method visibility from private to protected. The reason is that if someone wants to extend the Renderer, he/she has to copy the order_by_selected method into a new class.

Closes #

How to test the Change

Changelog Entry

Changed - order_by_selected visibility

Credits

Props @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@burhandodhy burhandodhy modified the milestones: 4.3.1, Future Release Sep 20, 2022
@felipeelia felipeelia modified the milestones: Future Release, 4.4.0 Sep 20, 2022
@felipeelia felipeelia added module:facets Issues related to the Facets functionality and removed needs discussion labels Sep 20, 2022
@felipeelia felipeelia merged commit ba9b072 into develop Oct 11, 2022
@felipeelia felipeelia deleted the burhan/change-method-visibility branch October 11, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felipeelia felipeelia

Labels
module:facets Issues related to the Facets functionality
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@burhandodhy @felipeelia