Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Indexable/Post/Post::format_args #3044

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Refactor Indexable/Post/Post::format_args #3044

merged 5 commits into from
Oct 11, 2022

Conversation

felipeelia
Copy link
Member

@felipeelia felipeelia commented Oct 3, 2022 •
edited
Loading

Description of the Change

This PR is a refactor of the Post::format_args method, breaking it into smaller methods.

To-do:

  • Add a WP filter to the array created in parse_filters
  • Refactor the smaller methods

Closes #2969

How to test the Change

Changelog Entry

Added - new ep_post_filters filter and refactor of the Post::format_args method

Credits

Props @felipeelia

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.4.0 milestone Oct 3, 2022
@felipeelia felipeelia self-assigned this Oct 3, 2022
@felipeelia felipeelia changed the title [WIP] Refactor Indexable/Post/Post::format_args Refactor Indexable/Post/Post::format_args Oct 3, 2022
@felipeelia felipeelia mentioned this pull request Oct 4, 2022
Merged
4 tasks
@felipeelia felipeelia merged commit 993cba7 into develop Oct 11, 2022
@felipeelia felipeelia deleted the chore/post-format_args-refactor branch October 11, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Refactor Indexable/Post/Post::format_args
1 participant
@felipeelia