Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the 'all' operator correctly within widgets #3076

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

felipeelia
Copy link
Member

Description of the Change

After #3045, the logic of all/any within widgets is wrongly applied. This PR fixes that behavior.

How to test the Change

Changelog Entry

Can be added to the #3045 entry

Credits

Props @felipeelia and @burhandodhy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@felipeelia felipeelia added this to the 4.4.0 milestone Oct 21, 2022
@felipeelia felipeelia self-assigned this Oct 21, 2022
Copy link
Contributor

@burhandodhy burhandodhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipeelia felipeelia merged commit 1f08172 into develop Oct 21, 2022
@felipeelia felipeelia deleted the fix/facets-op-within-widget branch October 21, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants