Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Utils\get_option() when possible #3078

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Use Utils\get_option() when possible #3078

merged 1 commit into from
Oct 26, 2022

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Oct 25, 2022 •
edited
Loading

Description of the Change

Just revising some redundant code. We should be using the Utils\get_option() when possible.

Changelog Entry

Changed - update code to use Utils\get_option() when possible

Credits

Props @rebeccahum

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@rebeccahum rebeccahum changed the title Use Utils when possible for ep_index_meta Use Utils\get_option() when possible Oct 25, 2022
@felipeelia felipeelia self-assigned this Oct 25, 2022
@felipeelia felipeelia added this to the 4.4.0 milestone Oct 25, 2022
@felipeelia felipeelia merged commit a160a5a into 10up:develop Oct 26, 2022
@rebeccahum rebeccahum deleted the ep_index_meta branch October 26, 2022 14:42
rebeccahum pushed a commit to Automattic/ElasticPress that referenced this pull request Oct 26, 2022
@felipeelia @rebeccahum
Merge pull request 10up#3078 from rebeccahum/ep_index_meta
4331002 
Use Utils\get_option() when possible
@rebeccahum rebeccahum mentioned this pull request Oct 26, 2022
Merged
4 tasks
rebeccahum added a commit to Automattic/ElasticPress that referenced this pull request Oct 28, 2022
@rebeccahum @felipeelia
4.2.2 additions (#176)
2d2dda7 
* Merge pull request 10up#3078 from rebeccahum/ep_index_meta

Use Utils\get_option() when possible

* Pull in changes from 10up#3081

x

* Hide admin notice to re-index and fix failing tests

Co-authored-by: Felipe Elia <felipe.elia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@felipeelia felipeelia

Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rebeccahum @felipeelia